disk index: use bits in ref count to store occupied #31004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
mm38_occupied_in_refount
branch
2 times, most recently
from
2711027 to
f677c55
Compare
jeffwashington
force-pushed
the
mm38_occupied_in_refount
branch
from
f677c55 to
fb977ce
Compare
brooksprumo
approved these changes
Mar 31, 2023
| @@ -190,6 +190,18 @@ impl<O: BucketOccupied> BucketStorage<O> { | |||
| unsafe { slice.get_unchecked_mut(0) } | |||
| } | |||
|
|
|||
| pub(crate) fn get_mut_from_parts<T: Sized>(item_slice: &mut [u8]) -> &mut T { | |||
There was a problem hiding this comment.
nit: We can remove the Sized bound from these two functions now. (Can be done in a different PR.)
There was a problem hiding this comment.
I fixed this up in the next one.
Codecov Report
@@ Coverage Diff @@
## master #31004 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 728 728
Lines 205456 205494 +38
=======================================
+ Hits 167562 167626 +64
+ Misses 37894 37868 -26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #30711
We'll be moving 0 or 1 slot entries into the index entry instead of the data file. This is a step in that direction.
Summary of Changes
Store the occupied/free bit in the refcount spare bits as an enum.
Fixes #