Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplifies quic::ConnectionTable::prune_oldest #30995

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

behzadnouri
Copy link
Contributor

Problem

Nested loops and branches.

Summary of Changes

Simplified the code using Iterator::min_by_key.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #30995 (f49acfd) into master (2672637) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #30995   +/-   ##
=======================================
  Coverage    81.5%    81.5%           
=======================================
  Files         728      728           
  Lines      205469   205463    -6     
=======================================
- Hits       167535   167532    -3     
+ Misses      37934    37931    -3     

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@behzadnouri behzadnouri merged commit 8a96b91 into solana-labs:master Mar 31, 2023
@behzadnouri behzadnouri deleted the conn-tbl-prune-oldest branch March 31, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants