disk bucket: refactor storage get/get_mut fns #30985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
get
/get_mut
family of functions on bucket_storageSummary of Changes
In commit 1, refactor the impl of the get/get_mut functions
In commit 2, move the functions within the file (no code changes)
In commit 3, remove get_from_parts functions, now that they are unused
In commit 4, fixup the impl from commit 1 😅