Use feature gate to set effective slot of loaded programs #30950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30950 +/- ##
========================================
Coverage 81.5% 81.5%
========================================
Files 727 727
Lines 205166 205444 +278
========================================
+ Hits 167295 167542 +247
- Misses 37871 37902 +31 |
Lichtso
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The new cache sets effective slot of a program at the next slot to the deployment slot. If the program gets upgraded or deployed, it won't be active for another slot. This behavior should be covered under the existing feature gate
delay_visibility_of_program_deployment.Summary of Changes
If
delay_visibility_of_program_deploymentis not active, set the effective slot to the deployment slot. If the feature is active, set it to the next slot.Fixes #