Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused bucket map direct add/unref calls #30942

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

see #30711

Summary of Changes

Remove unused apis for clarity, less testing, easier refactorings.

Fixes #

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #30942 (3213b32) into master (2646fb7) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #30942     +/-   ##
=========================================
- Coverage    81.5%    81.5%   -0.1%     
=========================================
  Files         728      728             
  Lines      205467   205437     -30     
=========================================
- Hits       167532   167506     -26     
+ Misses      37935    37931      -4     

@jeffwashington jeffwashington requested a review from HaoranYi March 29, 2023 13:55
@jeffwashington jeffwashington marked this pull request as ready for review March 29, 2023 13:55
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeffwashington jeffwashington merged commit 97af6aa into solana-labs:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants