Add more explict error messages for hardlink operations #30913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangzhu70
force-pushed
the
err_msg_build_storage_from_snapshot_dir
branch
from
8dfd304 to
143267b
Compare
Codecov Report
@@ Coverage Diff @@
## master #30913 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 727 727
Lines 205150 205166 +16
=======================================
+ Hits 167273 167301 +28
+ Misses 37877 37865 -12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Observed that when account_path was missing, there was IO failures without explicit error messages pin-pointing the exact error and location.
This is part of the work in #28745. Specifically the code in #30171 should be refined with more explicit error messages.
Summary of Changes
Map the dir and file operation errors to the errors with more explicit error messages for easier debugging.
Fixes #