Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discord invite links #30909

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

bw-solana
Copy link
Contributor

@bw-solana bw-solana commented Mar 27, 2023

Problem

See #30791 Old discords link (https://discord.com/invite/pquxPsq) being used in some places appears to be broken
image
We also have a few READMEs pointing to Discord that should probably point to SSE instead.

Summary of Changes

Update Discord link to https://solana.com/discord
Point README files at SSE (https://sola.na/sse) instead of Discord

@bw-solana bw-solana marked this pull request as ready for review March 27, 2023 17:28
@bw-solana bw-solana requested a review from jackcmay March 27, 2023 17:28
@bw-solana bw-solana linked an issue Mar 27, 2023 that may be closed by this pull request
@steviez
Copy link
Contributor

steviez commented Mar 27, 2023

Hmm, didn't realize we had the Discord link in several places like this. We should update outdated links regardless, but at the same time, we've kind of steered dev questions away from Discord. Maybe we should replace some of these Discord links with SSE link instead ?

@bw-solana
Copy link
Contributor Author

@jackcmay - Github suggested you as the best reviewer for these changes. Let me know if there's someone else who would be better to review

@bw-solana bw-solana requested a review from t-nelson March 29, 2023 15:44
steviez
steviez previously approved these changes Mar 29, 2023
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for switching those over. I agree with your decision to leave Discord link on docs.solana.com seeing as lots of our resources for operators are on a subpage there. But, others are constantly battling to keep Discord SNR high, so I'll defer to Trent (who I see you have already added as a reviewer)

@CriesofCarrots
Copy link
Contributor

How likely is the new discord invite code to expire in the future?

@t-nelson
Copy link
Contributor

The One True Discord Link ™️ is https://solana.com/discord

The cool kids link to SSE via https://sola.na/sse 😉

@bw-solana
Copy link
Contributor Author

How likely is the new discord invite code to expire in the future?

Depends on how the initial invite link was setup (source). Could be set to never expire. I hijacked the one from solana.com

@bw-solana
Copy link
Contributor Author

The One True Discord Link ™️ is https://solana.com/discord

The cool kids link to SSE via https://sola.na/sse 😉

What do the losers link to? Asking for a friend

@t-nelson
Copy link
Contributor

What do the losers link to? Asking for a friend

they link devs to discord 😠

@t-nelson t-nelson added the v1.14 label Mar 29, 2023
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks! i added v1.14 bp tag 'cause docs get published with the beta branch release pipeline

@bw-solana bw-solana merged commit 000b912 into solana-labs:master Mar 29, 2023
mergify bot pushed a commit that referenced this pull request Mar 29, 2023
* Update discord invite links

* Point to Stack Exchange for support

(cherry picked from commit 000b912)
bw-solana added a commit that referenced this pull request Mar 29, 2023
Update discord invite links (#30909)

* Update discord invite links

* Point to Stack Exchange for support

(cherry picked from commit 000b912)

Co-authored-by: Brennan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discord link in Solana documentations is broken
4 participants