remove uid concept from disk buckets #30836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
previously approved these changes
Mar 21, 2023
| /// mark this entry as unlocked | ||
| fn unlock(&mut self, expected: Uid) { |
There was a problem hiding this comment.
Removing the Uid param here is nice. Do you plan to also do that for try_lock()?
There was a problem hiding this comment.
yes, I should have. done now.
Codecov Report
@@ Coverage Diff @@
## master #30836 +/- ##
========================================
Coverage 81.4% 81.4%
========================================
Files 725 723 -2
Lines 203596 203281 -315
========================================
- Hits 165833 165655 -178
+ Misses 37763 37626 -137 |
brooksprumo
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #30711
uid concept implies a per-element header of more than 1 bit. We're working towards only having a single bit to represent free/in-use.
Summary of Changes
Remove concept of uid stored per entry. The pubkey is already unique per entry and has to be compared anyway.
solana/bucket_map/src/bucket.rs
Line 163 in 473534f
Fixes #