Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: ledger: Document ConfirmationTiming #30784

Merged
merged 1 commit into from
Mar 20, 2023
Merged

doc: ledger: Document ConfirmationTiming #30784

merged 1 commit into from
Mar 20, 2023

Conversation

ilya-bobyr
Copy link
Contributor

There is some logic related to how timing values are collected that is not immediately obvious. It is better to document it, rather than requiring everyone interested to reverse engineer it from the code.

@ilya-bobyr ilya-bobyr requested a review from bw-solana March 17, 2023 22:57
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #30784 (be2e18e) into master (ea7c72f) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #30784     +/-   ##
=========================================
- Coverage    81.3%    81.3%   -0.1%     
=========================================
  Files         724      724             
  Lines      203076   203076             
=========================================
- Hits       165273   165258     -15     
- Misses      37803    37818     +15     

There is some logic related to how timing values are collected that is
not immediately obvious.  It is better to document it, rather than
requiring everyone interested to reverse engineer it from the code.
Copy link
Contributor

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation good. No documentation bad. Thanks for this!

@ilya-bobyr ilya-bobyr merged commit f4cde7a into solana-labs:master Mar 20, 2023
@ilya-bobyr ilya-bobyr deleted the doc-metrics-ledger-ConfirmationTiming branch March 20, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants