Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: rework uid to use bits better #30563

Closed
wants to merge 1 commit into from

Conversation

jeffwashington
Copy link
Contributor

Problem

currently the accounts index uses a u64 per entry to hold a single bit of 'occupied'

Summary of Changes

64 entries share a single bitfield.

Fixes #

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Mar 15, 2023
@github-actions github-actions bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Mar 16, 2023
@jeffwashington
Copy link
Contributor Author

index file size decreases by 8 bytes for each allocated entry:
light blue line is this pr
others are various other disk index implementations
The top purple line is when we move a single data entry into the index file (note that this change is not present in that pr).

image

@jeffwashington jeffwashington force-pushed the ff93 branch 3 times, most recently from 256ca75 to efb4ae1 Compare March 21, 2023 15:45
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #30563 (310350b) into master (4285cb2) will decrease coverage by 0.1%.
The diff coverage is 83.3%.

@@            Coverage Diff            @@
##           master   #30563     +/-   ##
=========================================
- Coverage    81.4%    81.4%   -0.1%     
=========================================
  Files         723      723             
  Lines      203533   203573     +40     
=========================================
+ Hits       165845   165870     +25     
- Misses      37688    37703     +15     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant