Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old account snapshot directories to avoid the file existing hardlink error #30426

Merged
merged 5 commits into from
Feb 23, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix the hardlink failure
xiangzhu70 committed Feb 21, 2023
commit 0ddb28b57be5655418b1404e76edca1deacdd4b9
16 changes: 16 additions & 0 deletions runtime/src/snapshot_utils.rs
Original file line number Diff line number Diff line change
@@ -1014,6 +1014,22 @@ pub fn add_bank_snapshot(
// directory. Then, when adding new snapshots, the newer incomplete snapshot directory could
// be found. If so, it should be removed.
remove_bank_snapshot(slot, &bank_snapshots_dir)?;
} else {
// Even the snapshot directory is not found, still ensure the account snapshot directory
// is also clean. hardlink failure could happen if an old files exist when generating a
// new snapshot.
let account_paths = &bank.accounts().accounts_db.paths;
for account_path in account_paths {
let account_snapshot_path = account_path
.parent()
.unwrap()
brooksprumo marked this conversation as resolved.
Show resolved Hide resolved
.join("snapshot")
.join(bank.slot().to_string());
brooksprumo marked this conversation as resolved.
Show resolved Hide resolved
if account_snapshot_path.is_dir() {
// remove the account snapshot directory
fs::remove_dir_all(&account_snapshot_path)?;
}
}
}
fs::create_dir_all(&bank_snapshot_dir)?;