This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Cleanup tempoary pub modules #30268
Merged
Cleanup tempoary pub modules #30268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijunwangs
force-pushed
the
cleanup_tempoary_pub_modules
branch
from
054b8f3 to
f8b7784
Compare
CriesofCarrots
approved these changes
Feb 11, 2023
|
This one would be nice to have in v1.15. Would it depend on #30245? |
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2023
Clean up temporary_pub_modules in tpu_client and thin_client (cherry picked from commit d49b481)
Yes |
CriesofCarrots
pushed a commit
that referenced
this pull request
Feb 13, 2023
Clean up temporary_pub_modules in tpu_client and thin_client (cherry picked from commit d49b481)
mergify bot
added a commit
that referenced
this pull request
Feb 13, 2023
Cleanup tempoary pub modules (#30268) Clean up temporary_pub_modules in tpu_client and thin_client (cherry picked from commit d49b481) Co-authored-by: Lijun Wang <[email protected]>
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Mar 12, 2023
Clean up temporary_pub_modules in tpu_client and thin_client
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A number of temporary_pub modules in tpu_client and thin_client can now be safely removed or really made public as duplicate code is removed.
Summary of Changes
Remove temporary_pub code.
Fixes #