Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http to the url in remote-client script #30167

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

KirillLykov
Copy link
Contributor

Problem

Some time ago a new option was added to net script which allows to specify different types of clients.
For example: ./net/net.sh start --client-type [thin-client, tpu-client, rpc-client] but the problem is that there is http missing in the url.

Summary of Changes

Add http to url

Copy link
Contributor

@ryleung-solana ryleung-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested in all 3 cases? Is it needed for all 3 cases? The default thin-client seems to work fine without it; does this mean it will break with http prepended in that case for example?

@KirillLykov
Copy link
Contributor Author

Has this been tested in all 3 cases? Is it needed for all 3 cases? The default thin-client seems to work fine without it; does this mean it will break with http prepended in that case for example?

valid concern, I tested with rpc an tpu only, so of course for thin it is without http. Remove http from thin

@KirillLykov KirillLykov merged commit 9f35ffc into solana-labs:master Feb 8, 2023
nickfrosty pushed a commit to nickfrosty/solana that referenced this pull request Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants