More SlotMeta docs #3011
Merged
More SlotMeta docs #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3011 +/- ##
========================================
+ Coverage 74% 76.8% +2.7%
========================================
Files 129 129
Lines 20519 19786 -733
========================================
- Hits 15199 15197 -2
+ Misses 5320 4589 -731 |
rob-solana
reviewed
Feb 28, 2019
rob-solana
approved these changes
Feb 28, 2019
rob-solana
approved these changes
Feb 28, 2019
This was referenced Aug 4, 2021
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Oct 2, 2024
…olana-labs#3006) (solana-labs#3011) removes early return if prune_messages are empty (solana-labs#3006) Even if there are no outgoing prune messages we still need to generate outgoing push messages for packets just received, so the code should not early return here: https://github.com/anza-xyz/agave/blob/d2cc71f0d/gossip/src/cluster_info.rs#L2400-L2402 (cherry picked from commit ce15821) Co-authored-by: behzad nouri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SlotMeta descriptions lack precision
Summary of Changes
Take a stab at creating at better ones