Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainers references #29997

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Update maintainers references #29997

merged 2 commits into from
Jan 31, 2023

Conversation

joeaba
Copy link
Contributor

@joeaba joeaba commented Jan 31, 2023

Problem

There are some old maintainer references that need to be updated

Summary of Changes

Update all maintainer references

@joeaba joeaba requested a review from mvines January 31, 2023 01:09
@github-actions github-actions bot added the web3.js Related to the JavaScript client label Jan 31, 2023
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to web3.js/ should be made in a separate commit where a commit title like "chore: update maintainers reference" to make the build happy.
Otherwise looks good to me

@mvines
Copy link
Member

mvines commented Jan 31, 2023

revert: web3.js changes won't cut it, the script is too smart for that. You'll need to rewrite the commits such that the only commit that touches web3.js uses the correct semantic release commit title convention

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #29997 (3a87f74) into master (6489c20) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #29997   +/-   ##
=======================================
  Coverage    76.5%    76.5%           
=======================================
  Files          54       54           
  Lines        3129     3129           
  Branches      470      470           
=======================================
  Hits         2396     2396           
  Misses        568      568           
  Partials      165      165           

mvines
mvines previously approved these changes Jan 31, 2023
@mergify mergify bot dismissed mvines’s stale review January 31, 2023 05:33

Pull request has been modified.

@steveluscher
Copy link
Contributor

I wouldn't worry about it too much @joeaba. What @mvines said is correct, but I'd just jam it in, let it fail the web3.js build, and let the next web3.js commit paper over it.

@joeaba
Copy link
Contributor Author

joeaba commented Jan 31, 2023

Thanks, Chido just fixed the build, so it should be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web3.js Related to the JavaScript client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants