-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maintainers references #29997
Update maintainers references #29997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to web3.js/
should be made in a separate commit where a commit title like "chore: update maintainers reference" to make the build happy.
Otherwise looks good to me
revert: web3.js changes won't cut it, the script is too smart for that. You'll need to rewrite the commits such that the only commit that touches web3.js uses the correct semantic release commit title convention |
Codecov Report
@@ Coverage Diff @@
## master #29997 +/- ##
=======================================
Coverage 76.5% 76.5%
=======================================
Files 54 54
Lines 3129 3129
Branches 470 470
=======================================
Hits 2396 2396
Misses 568 568
Partials 165 165 |
Thanks, Chido just fixed the build, so it should be good now |
Problem
There are some old maintainer references that need to be updated
Summary of Changes
Update all maintainer references