BankingStage Refactor: Committer Simplify #29958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
force-pushed
the
refactor/banking_stage-committer-simplify
branch
from
1ba5b28 to
bbf918e
Compare
apfitzge
force-pushed
the
refactor/banking_stage-committer-simplify
branch
from
bbf918e to
59afe63
Compare
tao-stones
reviewed
Feb 1, 2023
| @@ -34,7 +34,6 @@ impl Committer { | |||
| batch: &TransactionBatch, | |||
| loaded_transactions: &mut [TransactionLoadResult], | |||
| execution_results: Vec<TransactionExecutionResult>, | |||
| sanitized_txs: &[SanitizedTransaction], | |||
There was a problem hiding this comment.
Good to have lesser arguments
There was a problem hiding this comment.
^ yeah, already passing the batch which contains the sanitized transactions
ryoqun
reviewed
Feb 2, 2023
| "find_and_send_votes", | ||
| ); | ||
| execute_and_commit_timings.find_and_send_votes_us = find_and_send_votes_time.as_us(); | ||
| let ((), find_and_send_votes_us) = measure_us!({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some clean up in
committer.rs.Summary of Changes
Fixes #