Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer] Fix parsing of some Pyth transactions. #29943

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Jan 27, 2023

Problem

Some transactions related to the Pyth oracle are not displayed properly.

Summary of Changes

  • Fix a bug where the instruction setMinimumPublishers was not recognized
  • Fix a bug where the public keys in the instruction payload to AddPublisher and DeletePublisher where not deserialized properly.

Fixes #

@github-actions github-actions bot added the explorer Related to the Solana Explorer webapp label Jan 27, 2023
@mergify mergify bot added the community Community contribution label Jan 27, 2023
@mergify mergify bot requested a review from a team January 27, 2023 02:41
@steviez
Copy link
Contributor

steviez commented Jan 27, 2023

@ngundotra - This one in your wheelhouse ?

@ngundotra
Copy link
Contributor

@guibescos can you post screenshots of the current (buggy) explorer and screenshots of what it looks like with your fix?

Please also post some links for myself and others to check.

Thank you

@guibescos
Copy link
Contributor Author

guibescos commented Jan 27, 2023

@guibescos
Copy link
Contributor Author

@ngundotra Please don't let this small PR get buried

@ngundotra
Copy link
Contributor

@guibescos Looks good to me. Thanks for fixing!

@ngundotra ngundotra merged commit c606d9b into solana-labs:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution explorer Related to the Solana Explorer webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants