Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Update turbine documentation #29906

Merged
merged 5 commits into from
Jan 27, 2023
Merged

Conversation

bw-solana
Copy link
Contributor

@bw-solana bw-solana commented Jan 25, 2023

Problem

Turbine docs are out of date and have some errors as described in #29766

Summary of Changes

Fix and restructure the text, diagrams, and calculations

@bw-solana bw-solana marked this pull request as ready for review January 25, 2023 18:20
@bw-solana
Copy link
Contributor Author

I'm reasonably happy with how this describes the current turbine behavior on MNB. I'm thinking I'll push in something along these lines and then immediately start working on a PR that describes the behavior once redundant turbine path is dropped (should be drastically simplified!). @behzadnouri - Are you okay with that?

@behzadnouri
Copy link
Contributor

I'm reasonably happy with how this describes the current turbine behavior on MNB. I'm thinking I'll push in something along these lines and then immediately start working on a PR that describes the behavior once redundant turbine path is dropped (should be drastically simplified!). @behzadnouri - Are you okay with that?

sounds good

Copy link
Contributor

@jbiseda jbiseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bw-solana bw-solana merged commit c1aac6d into solana-labs:master Jan 27, 2023
@bw-solana bw-solana deleted the turbine_doc branch January 30, 2023 15:13
mergify bot pushed a commit that referenced this pull request Apr 4, 2023
* Update turbine text, fix typos, shuffle organization, update diagrams, and fix error rate calculations

(cherry picked from commit c1aac6d)
jacobcreech pushed a commit that referenced this pull request Apr 4, 2023
Update turbine documentation (#29906)

* Update turbine text, fix typos, shuffle organization, update diagrams, and fix error rate calculations

(cherry picked from commit c1aac6d)

Co-authored-by: Brennan <[email protected]>
bw-solana added a commit to bw-solana/solana that referenced this pull request Jan 10, 2025
…olana-labs#31044)

Update turbine documentation (solana-labs#29906)

* Update turbine text, fix typos, shuffle organization, update diagrams, and fix error rate calculations

(cherry picked from commit c1aac6d)

Co-authored-by: Brennan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants