includes rent_epoch in vote-accounts sanity checks #29861
Conversation
solana-labs#26479 preserves rent epoch for rent-exempt accounts; since the feature got activated, vote accounts in stakes cache have identical rent_epoch field as the accounts in accounts-db. The commit verifies this in stakes-cache sanity checks.
| pubkey, vote_account, account | ||
| ); | ||
| if vote_account != &account { | ||
| error!("vote account mismatch: {pubkey}, {vote_account:?}, {account:?}"); | ||
| return Err(Error::VoteAccountMismatch(*pubkey)); |
There was a problem hiding this comment.
Does this halt the validator? IIRC, using the cache is not enabled yet on mnb?
There was a problem hiding this comment.
Does this halt the validator?
It does halt the validator at start up.
This code is only invoked at startup when deserializing bank:
https://github.com/solana-labs/solana/blob/0be194145/runtime/src/bank.rs#L1828-L1841
in order to obtain Stakes<StakeAccount> from Stakes<Delegation> for backward compatibility reasons mentioned in the link. As part of that, it performs these sanity checks.
IIRC, using the cache is not enabled yet on mnb?
We are not using stakes-cache for rewards calculations (yet), but stakes-cache is already used so many other places, including epoch-stakes calculations. Pubkeys for stakes accounts used in rewards calculations are also already obtained from stakes-cache.
There was a problem hiding this comment.
as a side note, I wonder why we aren't building this cache on startup instead of serializing it. We scan all accounts to generate the index. It seems we could recreate this then. Bank deserialization at load does take a while and all of this is duplicate information derivable from append vecs at startup. Then we would have no inconsistency checks and it seems we could remove code.
There was a problem hiding this comment.
Not sure where to obtain correct stake_history: StakeHistory field in stakes-cache, but, yeah, as for stake/vote accounts, those can be obtained from accounts-db. It would need a full accounts-db scan though.
I think since we already do serialize it, it would be just easier/faster to go with it.
Then we would have no inconsistency checks and it seems we could remove code.
Any inconsistency spotted by sanity checks here is only a symptom that there is a bug somewhere. The actual culprit of that inconsistency is somewhere else.
…29874) includes rent_epoch in vote-accounts sanity checks (#29861) #26479 preserves rent epoch for rent-exempt accounts. Since the feature got activated, vote accounts in stakes-cache have identical rent_epoch field as the accounts in accounts-db. The commit verifies this in stakes-cache sanity checks. (cherry picked from commit 8a14636) Co-authored-by: behzad nouri <[email protected]>
Problem
#26479 preserves rent epoch for rent-exempt accounts; since the feature got activated, vote accounts in stakes cache have identical
rent_epochfield as the accounts in accounts-db. The commit verifies this in stakes-cache sanity checks.Summary of Changes
includes
rent_epochin vote-accounts sanity checks