Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: always pass &Arc<Bank>, clone() only where consumed #2983

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

rob-solana
Copy link
Contributor

No description provided.

@garious
Copy link
Contributor

garious commented Feb 27, 2019

Nice, every clone() in the codebase is a red flag. This rule cuts down on a lot of them.

@rob-solana rob-solana added the automerge Merge this Pull Request automatically once CI passes label Feb 27, 2019
@solana-grimes solana-grimes merged commit 9adbc1d into solana-labs:master Feb 27, 2019
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #2983 into master will increase coverage by 3.4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #2983     +/-   ##
========================================
+ Coverage    73.2%   76.7%   +3.4%     
========================================
  Files         128     128             
  Lines       20564   19644    -920     
========================================
+ Hits        15071   15074      +3     
+ Misses       5493    4570    -923

1 similar comment
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #2983 into master will increase coverage by 3.4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #2983     +/-   ##
========================================
+ Coverage    73.2%   76.7%   +3.4%     
========================================
  Files         128     128             
  Lines       20564   19644    -920     
========================================
+ Hits        15071   15074      +3     
+ Misses       5493    4570    -923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants