Upgrades to Rust 1.66.1 #29827
Merged
Upgrades to Rust 1.66.1 #29827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yihau Can you add the Rust 1.66.1 toolchain to the appropriate CI agents so they'll be able to build this PR? Thanks in advance! |
|
Sure! Just pushed both of them 👻 |
mvines
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blog.rust-lang.org/2023/01/10/Rust-1.66.1.html
Note, this PR only updates the stable Rust version. In Rust 1.68 (what would be the normal nightly), the layout of structs can/does change. This is manifesting in the program runtime how a few types are passed to and from the vm. These types need to be audited to see if any require a stable-layout version.
Related: #29304