Abstract out AppendVec into AccountsFile enum #29815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhchiang-sol
commented
Jan 23, 2023
brooksprumo
reviewed
Feb 10, 2023
brooksprumo
reviewed
Feb 14, 2023
yhchiang-sol
changed the title
brooksprumo
reviewed
Feb 15, 2023
The implementation of the new storage using this enum is in #28790 (I haven't rebased yet so it's still using the old name I think we can keep the enum for now to maximize the flexibility. Once we've finalized the eventual API together with the cache and in-memory accounts representation, we can revisit here whether we want to keep the enum or do a trait instead. Converting a trait should be fast, but I would like to focus on the implementation for now, but without merging this PR I will need to constantly fix merge conflict 😂. |
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Mar 12, 2023
Abstracts out AppendVec into AccountsFile enum. This will allow different implementations of AccountsFile that support the AccountsDB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR abstracts out AppendVec into AccountsFile enum.
This will allow different implementations of AccountsFile that support the AccountsDB.