Replay slots from blocktree in new forks #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
changed the title
rob-solana
reviewed
Feb 27, 2019
rob-solana
reviewed
Feb 27, 2019
src/tvu.rs
Outdated
| @@ -34,7 +33,7 @@ use std::sync::{Arc, RwLock}; | |||
| use std::thread; | |||
|
|
|||
| pub struct TvuRotationInfo { | |||
| pub bank: Arc<Bank>, // Bank to use | |||
There was a problem hiding this comment.
you wouldn't rather just take a bank and a slot?
There was a problem hiding this comment.
@rob-solana block tree doesn't have any data for the next bank yet.
rob-solana
reviewed
Feb 27, 2019
src/replay_stage.rs
Outdated
| // RPC can be made aware of last slot's bank | ||
| to_leader_sender | ||
| .send(TvuRotationInfo { | ||
| tick_height: bank.tick_height(), |
There was a problem hiding this comment.
how come we don't just send the new Bank?
There was a problem hiding this comment.
@rob-solana because the notification will move into replay stage.
There was a problem hiding this comment.
@rob-solana where is the new bank? i just have a parent in that context.
garious
reviewed
Feb 27, 2019
carllin
reviewed
Feb 28, 2019
aeyakovenko
force-pushed
the
simple_replay_stage
branch
from
15e82ad to
25044d1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2975 +/- ##
========================================
+ Coverage 77.4% 77.4% +<.1%
========================================
Files 132 132
Lines 20257 20207 -50
========================================
- Hits 15680 15660 -20
+ Misses 4577 4547 -30 |
aeyakovenko
force-pushed
the
simple_replay_stage
branch
2 times, most recently
from
6bc7c16 to
65b8a66
Compare
|
looks tight |
aeyakovenko
force-pushed
the
simple_replay_stage
branch
from
65b8a66 to
fd0e764
Compare
aeyakovenko
changed the title
rob-solana
reviewed
Mar 2, 2019
rob-solana
reviewed
Mar 2, 2019
rob-solana
reviewed
Mar 2, 2019
src/replay_stage.rs
Outdated
| // TODO: Remove this soon once we boot the leader from ClusterInfo | ||
| cluster_info.write().unwrap().set_leader(leader_id); | ||
| if next_leader == my_id { | ||
| let mut wforks = bank_forks.write().unwrap(); |
There was a problem hiding this comment.
can you make this a one-liner? these wXXX or rXXX bug my eyes...
bank_forks.write().unwrap().insert(tpu_bank);
rob-solana
reviewed
Mar 2, 2019
rob-solana
approved these changes
Mar 2, 2019
aeyakovenko
force-pushed
the
simple_replay_stage
branch
from
1a6bb3e to
52bd20d
Compare
|
Can you rebase? |
aeyakovenko
force-pushed
the
simple_replay_stage
branch
from
52bd20d to
6b2697f
Compare
garious
approved these changes
Mar 2, 2019
aeyakovenko
added
the
automerge
wen-coding
added a commit
to wen-coding/solana
that referenced
this pull request
Oct 8, 2024
* wen_restart: Add wen_restart_coordinator argument. * rename LEADER_INDEX with COORDINATOR_INDEX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Replay stage is not tracking forks correctly as they are delivered to Blocktree.
Summary of Changes
Replay stage main loop:
Fixes #