This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
remove dated cost checking feature #29598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Had a quick chat with Tao, and the idea that had been previously discussed was to remove this never-activated feature and use a new one for the more sophisticated cost_tracker instead of re-using the feature. Since we never activated, no risks for change of behavior to break consensus with ripping this out, and we are just ripping out dead code. LGTM!
$ solana feature status 2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj
Feature | Status | Activation Slot | Description
2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj | inactive | NA | validator checks block cost against max limit in realtime, reject if exceeds.
Feature activation is not allowed at this time
$ solana feature status -ut 2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj
Feature | Status | Activation Slot | Description
2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj | inactive | NA | validator checks block cost against max limit in realtime, reject if exceeds.
Feature activation is not allowed at this time
$ solana feature status -ud 2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj
Feature | Status | Activation Slot | Description
2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj | inactive | NA | validator checks block cost against max limit in realtime, reject if exceeds.
Feature activation is not allowed at this time
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit 3d63f93) # Conflicts: # ledger/src/blockstore_processor.rs
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit 3d63f93) # Conflicts: # ledger/src/blockstore_processor.rs
tao-stones
added a commit
that referenced
this pull request
Jan 12, 2023
* remove dated cost checking feature (#29598) (cherry picked from commit 3d63f93) Co-authored-by: Tao Zhu <[email protected]> Co-authored-by: Tao Zhu <[email protected]>
tao-stones
added a commit
that referenced
this pull request
Jan 13, 2023
* remove dated cost checking feature (#29598) (cherry picked from commit 3d63f93) Co-authored-by: Tao Zhu <[email protected]> Co-authored-by: Tao Zhu <[email protected]>
t-nelson
added a commit
to t-nelson/solana
that referenced
this pull request
Mar 14, 2023
… (solana-labs#29656)" This reverts commit e7a57ca.
t-nelson
added a commit
that referenced
this pull request
Mar 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
An inactivated feature (#18994) that meant to check block cost limits during replay is dated - it only checks accumulates transaction costs against block limit, which is only a subset of
cost_tracker.would_fit(). Should symmetrically usecost_trackerin replay (in separate PR)Summary of Changes
Fixes #