Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI pipeline to only run checks step on version bump PRs (backport #29243) #29540

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 5, 2023

This is an automatic backport of pull request #29243 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

)

* Add logic to buildkite pipeline so version bump PRs don't run the full CI

(cherry picked from commit 0581fc2)
@willhickey
Copy link
Contributor

@t-nelson This isn't stability/compatibility/security but I think we can exclude dev-ops stuff from those constraints. What do you think?

@t-nelson
Copy link
Contributor

t-nelson commented Jan 5, 2023

so long as they're not going to introduce a supply chain attack

@willhickey
Copy link
Contributor

Oh yeah good point.

In this case I'm confident there's no supply chain attack risk. The regex looks specifically for "solana" version bumps. Tests with dependency version bumps were correctly treated as normal PRs (not version bumps)

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@willhickey willhickey merged commit b76b9da into v1.14 Jan 6, 2023
@willhickey willhickey deleted the mergify/bp/v1.14/pr-29243 branch January 6, 2023 18:50
CriesofCarrots pushed a commit that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants