fix: make toBytes actually return the type it's typehint claims

[cryptopapi997]

Problem

toBytes claims to return a Uint8Array when in reality it returns a Buffer. This isn't a huge problem as in 99.9% of cases these two work just as well for the caller, but causes issues in some edge cases (e.g. toString() on a Uint8Array and on a Buffer over the same bytes returns different strings). It's also a code smell, due to making this method fully redundant to the toBuffer() method in addition to its typehint not returning exactly what it says it should.

Summary of Changes

Actually convert the buffer to a Uint8Array

[codecov]

Codecov Report

Merging #29313 (a773f3b) into master (4267a15) will decrease coverage by 0.5%.
The diff coverage is n/a.

❗ Current head a773f3b differs from pull request most recent head 032e3a2. Consider uploading reports for the commit 032e3a2 to get more accurate results

@@            Coverage Diff            @@
##           master   #29313     +/-   ##
=========================================
- Coverage    77.1%    76.5%   -0.6%     
=========================================
  Files          55       54      -1     
  Lines        2934     3121    +187     
  Branches      408      468     +60     
=========================================
+ Hits         2264     2390    +126     
- Misses        529      567     +38     
- Partials      141      164     +23     

[steveluscher]

Nice! You're right that, while true that a Buffer fully implements Uint8Array from Typescript's perspective, folks have been bitten by that toString() behaviour before.

[steveluscher]

Previously: a622198.

Pull request has been modified.

[cryptopapi997]

I've removed the updated to the lock files - they were not necessary for the fix itself, but were necessary for part of the CI to run which complained about outdated lock files

[steveluscher]

Thanks for the fix!

See you in a couple of weeks, when this breaks something we couldn't predict.