patches shred::merkle::make_shreds_from_data when data is empty #29295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If data is empty, make_shreds_from_data will now return one data shred with empty data. This preserves invariants verified in tests regardless of data size.
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
If data is empty, make_shreds_from_data will now return one data shred with empty data. This preserves invariants verified in tests regardless of data size. (cherry picked from commit 92ca725)
mergify bot
added a commit
that referenced
this pull request
Dec 16, 2022
…port #29295) (#29306) patches shred::merkle::make_shreds_from_data when data is empty (#29295) If data is empty, make_shreds_from_data will now return one data shred with empty data. This preserves invariants verified in tests regardless of data size. (cherry picked from commit 92ca725) Co-authored-by: behzad nouri <[email protected]>
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
…na-labs#29295) If data is empty, make_shreds_from_data will now return one data shred with empty data. This preserves invariants verified in tests regardless of data size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Even though it does not happen in production,
make_shreds_from_datacan still work with empty data.Summary of Changes
If data is empty,
make_shreds_from_datawill now return one data shred with empty data. This preserves invariants verified in tests regardless of data size.