Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry for flakey local cluster test #29228

Merged
merged 1 commit into from
Dec 14, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions local-cluster/tests/local_cluster_flakey.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,27 @@ fn test_optimistic_confirmation_violation_without_tower() {
do_test_optimistic_confirmation_violation_with_or_without_tower(false);
}

enum RunResult {
Success,
FailNoViolation,
FailViolation,
}

fn do_test_optimistic_confirmation_violation_with_or_without_tower(with_tower: bool) {
let mut retry = 10;
while retry > 0 {
match do_test_optimistic_confirmation_violation_with_or_without_tower_inner(with_tower) {
RunResult::Success => {
return;
}
_ => {
retry -= 1;
}
}
}
panic!("optimistic confirmation violation with or without tower failed after 10 trial");
}

// A bit convoluted test case; but this roughly follows this test theoretical scenario:
//
// Step 1: You have validator A + B with 31% and 36% of the stake. Run only validator B:
Expand Down Expand Up @@ -78,7 +99,9 @@ fn test_optimistic_confirmation_violation_without_tower() {
// With the persisted tower:
// `A` should not be able to generate a switching proof.
//
fn do_test_optimistic_confirmation_violation_with_or_without_tower(with_tower: bool) {
fn do_test_optimistic_confirmation_violation_with_or_without_tower_inner(
with_tower: bool,
) -> RunResult {
solana_logger::setup_with_default(RUST_LOG_FILTER);

// First set up the cluster with 4 nodes
Expand Down Expand Up @@ -346,13 +369,17 @@ fn do_test_optimistic_confirmation_violation_with_or_without_tower(with_tower: b
let expects_optimistic_confirmation_violation = !with_tower;
if bad_vote_detected != expects_optimistic_confirmation_violation {
if bad_vote_detected {
panic!("No violation expected because of persisted tower!");
error!("No violation expected because of persisted tower!");
return RunResult::FailNoViolation;
} else {
panic!("Violation expected because of removed persisted tower!");
error!("Violation expected because of removed persisted tower!");
return RunResult::FailViolation;
}
} else if bad_vote_detected {
info!("THIS TEST expected violations. And indeed, there was some, because of removed persisted tower.");
} else {
info!("THIS TEST expected no violation. And indeed, there was none, thanks to persisted tower.");
}

RunResult::Success
}