This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
test_shrink_candidate_slots uses write cache #29145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
nov50_18_another
branch
from
55b2cfd to
ee6236b
Compare
brooksprumo
reviewed
Dec 8, 2022
| @@ -13771,7 +13771,7 @@ pub mod tests { | |||
| fn test_shrink_candidate_slots() { | |||
| solana_logger::setup(); | |||
|
|
|||
| let accounts = AccountsDb::new_single_for_tests(); | |||
| let mut accounts = AccountsDb::new_single_for_tests(); | |||
There was a problem hiding this comment.
Is the intent to also enable the write cache here?
There was a problem hiding this comment.
The write cache will be enabled globally shortly. The shrink ratio parameter doesn't affect the v1 shrink code path anyway.
There was a problem hiding this comment.
Gotcha.
Does
accounts.shrink_candidate_slots();
end up calling the v1 shrink code path?
There was a problem hiding this comment.
doesn't look like it. But how we create append vecs is different. Whatever the case, I updated the test to use the write cache completely. I just have to back this out once everyone can only use the write cache.
jeffwashington
force-pushed
the
nov50_18_another
branch
from
ee6236b to
686c96a
Compare
brooksprumo
approved these changes
Dec 8, 2022
carllin
approved these changes
Dec 8, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Dec 8, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Dec 9, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Dec 9, 2022
jeffwashington
added a commit
that referenced
this pull request
Dec 9, 2022
* test_shrink_candidate_slots uses write cache (#29145) * add tests for collect_from_existing_account
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
* test_shrink_candidate_slots uses write cache (solana-labs#29145) * add tests for collect_from_existing_account
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
* test_shrink_candidate_slots uses write cache (solana-labs#29145) * add tests for collect_from_existing_account
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
migrating all tests to use write cache
Summary of Changes
Fixes #