support for accounts tests loading accounts with excluded feature

[jeffwashington]

Problem

This allows us to test with and without the activation of the feature in #28690, which has to do with fixing rent_epoch at a consistent value for rent exempt accounts.

Summary of Changes

Introduce parameter for excluding features from activation in tests in accounts.rs.

Fixes #

[brooksprumo]

I did something that sounds similar for the stake program to test out raise the minimum delegation amount. I ran basically every test with and without the feature.

The feature settings:

solana/programs/stake/src/stake_instruction.rs

Lines 527 to 537 in 9eedc18

	/// The "new" behavior enables all features
	fn feature_set_new_behavior() -> FeatureSet {
	FeatureSet::all_enabled()
	}
	/// The "old" behavior is before the stake minimum delegation was raised
	fn feature_set_old_behavior() -> FeatureSet {
	let mut feature_set = feature_set_new_behavior();
	feature_set.deactivate(&feature_set::stake_raise_minimum_delegation_to_1_sol::id());
	feature_set
	}

The tests:

solana/programs/stake/src/stake_instruction.rs

Lines 4143 to 4145 in 9eedc18

	#[test_case(feature_set_old_behavior(); "old_behavior")]
	#[test_case(feature_set_new_behavior(); "new_behavior")]
	fn test_split_full_amount_minimum_stake_delegation(feature_set: FeatureSet) {

[brooksprumo]

For all of these changes where the optional excluded features is None, what's the benefit of calling load_accounts_with_excluded_features() vs load_accounts()?

[jeffwashington]

Because they're going to change soon, once there is a feature.

[jeffwashington]

and then once the feature is activated, this can all go away again.

[jeffwashington]

I did something that sounds similar for the stake program to test out raise the minimum delegation amount. I ran basically every test with and without the feature.

The feature settings:

solana/programs/stake/src/stake_instruction.rs

Lines 527 to 537 in 9eedc18

	/// The "new" behavior enables all features
	fn feature_set_new_behavior() -> FeatureSet {
	FeatureSet::all_enabled()
	}
	/// The "old" behavior is before the stake minimum delegation was raised
	fn feature_set_old_behavior() -> FeatureSet {
	let mut feature_set = feature_set_new_behavior();
	feature_set.deactivate(&feature_set::stake_raise_minimum_delegation_to_1_sol::id());
	feature_set
	}

The tests:

solana/programs/stake/src/stake_instruction.rs

Lines 4143 to 4145 in 9eedc18

	#[test_case(feature_set_old_behavior(); "old_behavior")]
	#[test_case(feature_set_new_behavior(); "new_behavior")]
	fn test_split_full_amount_minimum_stake_delegation(feature_set: FeatureSet) {

I did something that sounds similar for the stake program to test out raise the minimum delegation amount. I ran basically every test with and without the feature.

The feature settings:

solana/programs/stake/src/stake_instruction.rs

Lines 527 to 537 in 9eedc18

	/// The "new" behavior enables all features
	fn feature_set_new_behavior() -> FeatureSet {
	FeatureSet::all_enabled()
	}
	/// The "old" behavior is before the stake minimum delegation was raised
	fn feature_set_old_behavior() -> FeatureSet {
	let mut feature_set = feature_set_new_behavior();
	feature_set.deactivate(&feature_set::stake_raise_minimum_delegation_to_1_sol::id());
	feature_set
	}

The tests:

solana/programs/stake/src/stake_instruction.rs

Lines 4143 to 4145 in 9eedc18

	#[test_case(feature_set_old_behavior(); "old_behavior")]
	#[test_case(feature_set_new_behavior(); "new_behavior")]
	fn test_split_full_amount_minimum_stake_delegation(feature_set: FeatureSet) {

An issue is sometimes I can't deactivate it on the bank because at that point it already exists and its initial existence can change the behavior of the test. I have run into this with this feature.

[brooksprumo]

lgtm