Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #28945 #29127

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Revert #28945 #29127

merged 1 commit into from
Dec 6, 2022

Conversation

HaoranYi
Copy link
Contributor

@HaoranYi HaoranYi commented Dec 6, 2022

Problem

Revert #28945 because it adds external dependency on 'wc'.

Summary of Changes

Fixes #

@HaoranYi HaoranYi changed the title revert #28945 Revert #28945 Dec 6, 2022
@HaoranYi HaoranYi requested review from mvines and t-nelson December 6, 2022 21:42
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@@ -387,21 +385,25 @@ fn parse_disk_stats(reader_diskstats: &mut impl BufRead) -> Result<DiskStats, St
Ok(stats)
}

pub struct SystemMonitorStatsReportConfig {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind popping the config struct out and re-introducing after merging this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaoranYi HaoranYi merged commit 33b1524 into solana-labs:master Dec 6, 2022
@HaoranYi HaoranYi deleted the revert2 branch December 6, 2022 23:09
@mvines
Copy link
Member

mvines commented Dec 7, 2022

ty for this

gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Dec 16, 2022
nickfrosty pushed a commit to nickfrosty/solana that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants