This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
ledger-tool create-snapshot uses write cache #29119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
nov50_16_2
branch
2 times, most recently
from
8541aae to
fac19d0
Compare
jeffwashington
force-pushed
the
nov50_16_2
branch
from
fac19d0 to
77d759a
Compare
jeffwashington
force-pushed
the
nov50_16_2
branch
from
0ce824c to
b254da1
Compare
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
* ledger-tool create-snapshot uses write cache * ledger tool create snapshot works with write cache
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
* ledger-tool create-snapshot uses write cache * ledger tool create snapshot works with write cache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Migrating everything to use write cache so we can eliminate the old code path.
ledger-tool create-snapshot does not use the write cache.
The biggest hang up with using the write cache is a call to
calculate_capitalization. That tries to scan storages. But, if we have not written to storages yet because we're using the write cache, then we can't calculate cap correctly. But, if we flush to the write cache, then we later update sys vars in the same slot. As a result, we violate some design constraints by writing to a slot that has already been flushed from the write cache.A solution to this is to have
calculate_capitalizationuse the index to calculate that capitalization. This could be revisited later but is sufficient for now since it does not affect any real validators.Summary of Changes
Fixes #