Don't use global storage account #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
remove-storage-system-account
branch
2 times, most recently
from
ab10549 to
3536572
Compare
|
Awesome, thanks for the quick work! |
Other accounts would not be able to modify the system accounts userdata.
sakridge
force-pushed
the
remove-storage-system-account
branch
from
3536572 to
39632c1
Compare
garious
approved these changes
Feb 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #2909 +/- ##
========================================
+ Coverage 78.3% 78.3% +<.1%
========================================
Files 127 127
Lines 19534 19478 -56
========================================
- Hits 15299 15269 -30
+ Misses 4235 4209 -26 |
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Sep 28, 2024
…solana-labs#2687) (solana-labs#2909) remove disable_block_production_forwarding cli flag (solana-labs#2687) (cherry picked from commit df892c4) Co-authored-by: Andrew Fitzgerald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Other accounts would not be able to modify the system accounts userdata.
Summary of Changes
Use accounts[0] keyed account as storage state holder. Each validator will have to create this storage account.
Fixes #