fix: verify commitment level when confirming transactions with one-shot fetch #28969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
deleted the
web3-match-commitments-when-confirming-transactions
branch
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
…ot fetch (solana-labs#28969) * Rename `subscriptionCommitment` to `confirmationCommitment` * Reorganize status checking code to return early if `value` is `null` * Bail if the one-shot signature result does not meet the target commitment
This was referenced Dec 20, 2022
This was referenced Dec 23, 2022
This was referenced Dec 28, 2022
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
…ot fetch (solana-labs#28969) * Rename `subscriptionCommitment` to `confirmationCommitment` * Reorganize status checking code to return early if `value` is `null` * Bail if the one-shot signature result does not meet the target commitment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A small bug snuck in at #28290 where the one-shot fetch for the current commitment status could result in a transaction being confirmed when it shouldn't be. The reason was because we did not check that the result met the target commitment.
Summary of Changes
When fetching the one-shot
getSignatureStatusfor a given transaction, make sure that the instantaneous signature status at least meets the target commitment.