Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove obsoleted comment #28960

Merged
merged 1 commit into from
Nov 28, 2022
Merged

remove obsoleted comment #28960

merged 1 commit into from
Nov 28, 2022

Conversation

tao-stones
Copy link
Contributor

Problem

A TODO comment about re-iterate high priority txs more often is outdated since MI.

Summary of Changes

remove it

Fixes #

@tao-stones tao-stones requested a review from apfitzge November 28, 2022 17:34
apfitzge
apfitzge approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to remove this since we're aware and addressing this actively. It largely went away with multi-iterator, but we still have retryable AccountInUse errors between threads. Scheduler makes this go away

@tao-stones tao-stones added the automerge Merge this Pull Request automatically once CI passes label Nov 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2022

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Nov 28, 2022
@tao-stones tao-stones added the automerge Merge this Pull Request automatically once CI passes label Nov 28, 2022
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Nov 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2022

automerge label removed due to a CI failure

@tao-stones tao-stones merged commit 9f37047 into solana-labs:master Nov 28, 2022
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Dec 16, 2022
@tao-stones @gnapoli23
remove obsoleted comment (solana-labs#28960)
2378e33
nickfrosty pushed a commit to nickfrosty/solana that referenced this pull request Jan 4, 2023
@tao-stones @nickfrosty
remove obsoleted comment (solana-labs#28960)
436c273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apfitzge apfitzge apfitzge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tao-stones @apfitzge