Feature/multi-iterator-scanner-read-locks #28862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
commented
Nov 17, 2022
| } | ||
|
|
||
| /// Check if a sanitized message's account locks are available. | ||
| fn check_sanitized_message_account_locks(&self, message: &SanitizedMessage) -> bool { |
There was a problem hiding this comment.
Considering a follow-up change here. We really only need to check the non-static (loaded from lookup) here.
apfitzge
commented
Nov 17, 2022
apfitzge
force-pushed
the
feature/multi-iterator-scanner-read-locks
branch
from
71ecfc6 to
84ae0f0
Compare
apfitzge
force-pushed
the
feature/multi-iterator-scanner-read-locks
branch
from
84ae0f0 to
31129bf
Compare
apfitzge
commented
Nov 19, 2022
tao-stones
reviewed
Nov 22, 2022
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
consume_scan_should_process_packet doesn't consider read-locks
Summary of Changes
Consider read-locks, also wrap in a struct so these checks are simpler
Fixes #28853