stop testing rent_epoch in sbf programs #28806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
requested review from
jackcmay,
Lichtso,
alessandrod and
ryoqun
|
As Jack already commented, we can't change the layout of the ABI in programs which are deployed already. So deleting theses lines won't do anything (besides losing coverage). Instead, change them to test against the new value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm trying to get rid of
rent_epochIn the meantime, it will soon have a fixed value for all rent_exempt accounts.
see: #28690
Summary of Changes
Stop testing it in sbf program tests.
Fixes #