Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signed repair request test fixes/cleanup #28691

Merged

Conversation

jbiseda
Copy link
Contributor

@jbiseda jbiseda commented Nov 1, 2022

Problem

pubkey mismatch in tests

Summary of Changes

fix/cleanup signed repair request tests

Fixes #

@jbiseda jbiseda marked this pull request as ready for review November 1, 2022 00:37
@jbiseda jbiseda requested a review from behzadnouri November 1, 2022 00:37
Copy link
Contributor

@behzadnouri behzadnouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shouldn't we also add some debug_assert that keys match?

@jbiseda jbiseda merged commit e10d958 into solana-labs:master Nov 16, 2022
mergify bot pushed a commit that referenced this pull request Nov 16, 2022
mergify bot pushed a commit that referenced this pull request Nov 16, 2022
mergify bot added a commit that referenced this pull request Nov 16, 2022
signed repair request test fixes/cleanup (#28691)

(cherry picked from commit e10d958)

Co-authored-by: Jeff Biseda <[email protected]>
mergify bot added a commit that referenced this pull request Nov 16, 2022
signed repair request test fixes/cleanup (#28691)

(cherry picked from commit e10d958)

Co-authored-by: Jeff Biseda <[email protected]>
xiangzhu70 pushed a commit to xiangzhu70/solana that referenced this pull request Nov 16, 2022
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Dec 16, 2022
nickfrosty pushed a commit to nickfrosty/solana that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants