This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
propose refactor banking buffer to include writable accounts info #28577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for documenting the idea! |
apfitzge
reviewed
Oct 25, 2022
| ... ... | ||
| ] | ||
| ), | ||
| (98, [ ([tx1, ...]), // txs write to account A |
There was a problem hiding this comment.
this tx1, tx2, tx3 are unrelated to the tx1, tx3 from the 99 priority bin, right? Can we change the suffix numbers so that is more clear
There was a problem hiding this comment.
they could be the transactions do exactly same thing, except different priority.
|
|
||
| # concerns | ||
|
|
||
| 1. Too many priority level may hurt performance, |
There was a problem hiding this comment.
Do we know what the priority distribution looks like in these conditions:
- Normal conditions
- Busy mint events?
|
|
||
| /// a FIFO queue for packets that write to same account at same priority | ||
| struct Packets { | ||
| packets: deque<Arc<DeserializedPacket>>, |
There was a problem hiding this comment.
quick note - if we're storing attempted, retryable, forwarded on the DeserializedPacket we shouldn't wrap DeserializedPacket in an Arc - need some interior mutability (refcell?).
github-actions
bot
added
the
stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some recent works on improving block producing efficiency lead to the idea of refactoring banking buffer. While it may not be the most urgent task, but worth document for discussion.
Summary of Changes
Fixes #