Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 28541 no-op #28542

Merged
merged 1 commit into from
Oct 24, 2022
Merged

feature 28541 no-op #28542

merged 1 commit into from
Oct 24, 2022

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented Oct 21, 2022

Problem

we need this feature in master, for activation on mnb.
However, it is not compatible with mnb.
So, when it is activated on mnb, it will do nothing.
The changes affected by this feature's activation will only exist in 1.14 and only temporarily long enough to fix testnet.

Summary of Changes

Feature Gate Issue: #28541

Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. This should also be backported too, yes?

Since #28543 is already merged to v1.14, will this backport only to v1.13?

@jeffwashington
Copy link
Contributor Author

Lgtm. This should also be backported too, yes?

Since #28543 is already merged to v1.14, will this backport only to v1.13?

This is already in 1.14. It never needs to go to 1.13

@jeffwashington jeffwashington merged commit 1ff2740 into solana-labs:master Oct 24, 2022
@brooksprumo
Copy link
Contributor

This is already in 1.14. It never needs to go to 1.13

I thought the reason to add this feature was to make all the versions/clusters the same/have the same feature set? If the feature doesn't get backported to v1.13, why bother putting it into master?

@jeffwashington
Copy link
Contributor Author

I thought the reason to add this feature was to make all the versions/clusters the same/have the same feature set? If the feature doesn't get backported to v1.13, why bother putting it into master?

All the versions once 1.14 is the minimum supported version. There is no reason to push this to 1.13. We don't need to activate the feature until it is available everywhere on mnb, which will be when 1.14 is the minimum. From that point forward, the feature set will be consistent. There are features like epoch accounts hash which will only be in 1.15. This is a feature that is only in 1.14+.

@brooksprumo brooksprumo added the feature-gate Pull Request adds or modifies a runtime feature gate label Oct 24, 2022
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Oct 24, 2022
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Oct 24, 2022
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Oct 24, 2022
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Nov 1, 2022
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Nov 1, 2022
jeffwashington added a commit that referenced this pull request Nov 1, 2022
* Revert "testnet fixup: only update rent_epoch on load until feature (#28542)"

This reverts commit 9e57fb5.

* feature 28541 no-op (#28542)
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Dec 16, 2022
nickfrosty pushed a commit to nickfrosty/solana that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants