-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature 28541 no-op #28542
feature 28541 no-op #28542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. This should also be backported too, yes?
Since #28543 is already merged to v1.14, will this backport only to v1.13?
This is already in 1.14. It never needs to go to 1.13 |
I thought the reason to add this feature was to make all the versions/clusters the same/have the same feature set? If the feature doesn't get backported to v1.13, why bother putting it into master? |
All the versions once 1.14 is the minimum supported version. There is no reason to push this to 1.13. We don't need to activate the feature until it is available everywhere on mnb, which will be when 1.14 is the minimum. From that point forward, the feature set will be consistent. There are features like epoch accounts hash which will only be in 1.15. This is a feature that is only in 1.14+. |
…olana-labs#28542)" This reverts commit 9e57fb5.
…olana-labs#28542)" This reverts commit 9e57fb5.
Problem
we need this feature in master, for activation on mnb.
However, it is not compatible with mnb.
So, when it is activated on mnb, it will do nothing.
The changes affected by this feature's activation will only exist in 1.14 and only temporarily long enough to fix testnet.
Summary of Changes
Feature Gate Issue: #28541