Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create internal method for subscribing to subscription state changes #28525

Closed
wants to merge 1 commit into from
Closed

chore: create internal method for subscribing to subscription state changes #28525

wants to merge 1 commit into from

Conversation

steveluscher
Copy link
Contributor

Problem

In #28290 we need to be able to wait on an onSignature subscription having been established, after which we do more work.

Summary of Changes

  • Create an internal method of tracking the state of every subscription.

@steveluscher steveluscher added the javascript Pull requests that update Javascript code label Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #28525 (d39b3fc) into master (831ed96) will decrease coverage by 0.1%.
The diff coverage is 53.3%.

❗ Current head d39b3fc differs from pull request most recent head e6672e8. Consider uploading reports for the commit e6672e8 to get more accurate results

@@            Coverage Diff            @@
##           master   #28525     +/-   ##
=========================================
- Coverage    77.1%    77.0%   -0.2%     
=========================================
  Files          55       55             
  Lines        2934     2956     +22     
  Branches      408      414      +6     
=========================================
+ Hits         2264     2278     +14     
- Misses        529      536      +7     
- Partials      141      142      +1     

@steveluscher
Copy link
Contributor Author

This ended up being merged as part of #28290 because GitHub is great at doing stacked PRs.

@steveluscher steveluscher deleted the subscription-state-change-callbacks branch December 7, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant