fix: wrap _rpcWebSocketGeneration around when about to overflow #28428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know that 2^53 is a lot, and that 2^53ms is a whole lot of days' worth of time, but stranger things have happened. Imagine if this actually fixed something. |
This was referenced Nov 9, 2022
This was referenced Nov 28, 2022
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
This was referenced Dec 16, 2022
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's conceivable that someone could open up so many WebSocket connections (ie. in a long running Node process) so as to exhaust this index. JavaScript integers, after all, have a maximum value of
Number.MAX_SAFE_INTEGER.Upon hearing a report of someone with a script that works from Saturday to Thursday but then crashes with the dreaded infinite recursion bug (see solana-labs/solana-web3.js#1106) I immediately thought that this index might be overflowing, essentially pinning it to a constant value from
Number.MAX_SAFE_INTEGER + 1onward.Summary of Changes
Wrap the index back around to 0 after hitting
Number.MAX_SAFE_INTEGER.Addresses solana-labs/solana-web3.js#1106. Closes #28426.