Add SetAuthorityChecked instruction to bpf loader #28424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xripleys
changed the title
|
as for the cli changes, there are a couple ways to do this:
thoughts? |
0xripleys
commented
Oct 17, 2022
I prefer 2) as well but cli changes should be done in a separate PR |
jstarry
reviewed
Oct 17, 2022
jstarry
reviewed
Oct 20, 2022
Co-authored-by: Justin Starry <[email protected]>
jstarry
added
the
feature-gate
jstarry
previously approved these changes
Oct 29, 2022
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
|
@0xripleys can you please fix up the checks |
|
not done fixing CI yet (trying to run CI locally on my mac but having some issues) |
|
ok the checks test should pass. i ran the other tests locally as well but ran into what i think are flakes + some mac specific issues. @jstarry do you mind running the CI again? |
|
@jstarry noob question, do i have to do anything (eg merge master into my branch) to kick off the other CI jobs? |
Nope, sorry that's my responsibility. In the past the CI label wasn't required, looks like it is now, thanks for the ping on that. |
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
* SetAuthorityChecked * restore old logic for loader * add more upgrade authority checked test cases * setBufferAuthority checked tests * format * add set_buffer_authority_checked instruction to sdk * Update transaction-status/src/parse_bpf_loader.rs Co-authored-by: Justin Starry <[email protected]> * add is_set_authority_checked function * fix set_buffer_authority_checked sdk instruction * feature gate setAuthorityChecked * add bpf loader tests for setAuthorityChecked ixs * test that you can set to same authority * allow set_authority_checked to be called via cpi (if feature is enabled) * fix ci * fmt Co-authored-by: Justin Starry <[email protected]> Co-authored-by: Justin Starry <[email protected]>
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
* SetAuthorityChecked * restore old logic for loader * add more upgrade authority checked test cases * setBufferAuthority checked tests * format * add set_buffer_authority_checked instruction to sdk * Update transaction-status/src/parse_bpf_loader.rs Co-authored-by: Justin Starry <[email protected]> * add is_set_authority_checked function * fix set_buffer_authority_checked sdk instruction * feature gate setAuthorityChecked * add bpf loader tests for setAuthorityChecked ixs * test that you can set to same authority * allow set_authority_checked to be called via cpi (if feature is enabled) * fix ci * fmt Co-authored-by: Justin Starry <[email protected]> Co-authored-by: Justin Starry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Transferring upgrade authorities are scary: #27932
Summary of Changes
SetAuthorityCheckedinstruction to bpf upgradeable loaderFixes # #27932
Feature Gate Issue: #28627