remove expected rent collection and rehashing completely #28422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
oct1_2
branch
2 times, most recently
from
fc0fe52 to
3508383
Compare
jeffwashington
force-pushed
the
oct1_2
branch
from
3508383 to
b255ed6
Compare
brooksprumo
reviewed
Oct 17, 2022
If they do, their machine will fail consensus until both features gets activated. That option is hidden on the cli. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
(cherry picked from commit 28a89a1) # Conflicts: # accounts-bench/src/main.rs # core/src/accounts_hash_verifier.rs # core/tests/epoch_accounts_hash.rs # runtime/benches/accounts.rs # runtime/src/accounts_background_service.rs # runtime/src/accounts_db.rs # runtime/src/expected_rent_collection.rs # runtime/src/snapshot_package.rs
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Oct 21, 2022
jeffwashington
added a commit
that referenced
this pull request
Oct 21, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Oct 21, 2022
This reverts commit 5571aca.
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Oct 21, 2022
This reverts commit 5571aca.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For eliminating rewrites, to maintain consensus and accounts hash calculation while developing and testing, and presumably during roll out, there was a system in place to allow any validator to skip rewrites and still maintain consensus.
A better way to solve the issue with hashes and eliminating rewrites is to stop updating
rent_epochfor rent-exempt accounts and to stop hashing the slot for the account hash. These 2 projects (features) are underway. This codepath complicates removing the slot from the account hash feature.Summary of Changes
Remove the rehash/expected rent epoch code path completely and wait for the features. Once we stop updating
rent_epochand using the slot in the hash, the hash is always complete.Fixes #