get rid of unnecessary mut #28017
Merged
get rid of unnecessary mut #28017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
sep21_2
branch
from
e513da1 to
8091662
Compare
brooksprumo
approved these changes
Sep 26, 2022
| fn get<T: Sized>(&self, ix: u64) -> &T { | ||
| let item_slice = self.get_slice_internal::<T>(ix); | ||
| unsafe { | ||
| let item = item_slice.as_ptr() as *const T; |
There was a problem hiding this comment.
nit: Can this let line be moved out of the unsafe block? Iiuc, only the deref needs to be scoped by unsafe.
Same for the get_mut fn as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
1.14 is having oom issues
hash calc can perform its operations on files instead of using ram spikes
Some refactoring needs to occur for this.
Summary of Changes
Make non-mut version of access to loaded hash cache data.
This will be used later to remove the current requirement of having a &mut self
Fixes #