Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web3.js: replace casts with not-null assertions #27883

Merged
merged 1 commit into from
Nov 29, 2022
Merged

web3.js: replace casts with not-null assertions #27883

merged 1 commit into from
Nov 29, 2022

Conversation

macalinao
Copy link
Contributor

Problem

Replace casts with not null assertions

@mergify mergify bot added the community Community contribution label Sep 17, 2022
@mergify mergify bot requested a review from a team September 17, 2022 23:46
@steveluscher
Copy link
Contributor

Notes: according to the TS Playground, foo as number and foo! compile to the identical JavaScript code, so this PR is a type-only change.

@steveluscher steveluscher merged commit 19ec2dc into solana-labs:master Nov 29, 2022
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Dec 16, 2022
@macalinao @gnapoli23
chore: replace casts with not-null assertions (solana-labs#27883)
00838f2
@snyk-bot snyk-bot mentioned this pull request Dec 22, 2022
Open
This was referenced Dec 23, 2022
Open
Open
This was referenced Dec 28, 2022
Open
Open
nickfrosty pushed a commit to nickfrosty/solana that referenced this pull request Jan 4, 2023
@macalinao @nickfrosty
chore: replace casts with not-null assertions (solana-labs#27883)
f713775
@snyk-bot snyk-bot mentioned this pull request Jan 8, 2023
Open
This was referenced Jan 9, 2023
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jan 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
web3.js Roadmap – November 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@macalinao @steveluscher