-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web3.js: remove redundant 'Buffer' from 'Account' class #27865
Merged
steveluscher
merged 1 commit into
solana-labs:master
from
saber-hq:igm/remove-buffer-redundant
Nov 29, 2022
Merged
web3.js: remove redundant 'Buffer' from 'Account' class #27865
steveluscher
merged 1 commit into
solana-labs:master
from
saber-hq:igm/remove-buffer-redundant
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27865 +/- ##
=========================================
+ Coverage 77.3% 77.4% +0.1%
=========================================
Files 55 55
Lines 2889 2910 +21
Branches 402 404 +2
=========================================
+ Hits 2234 2255 +21
Misses 514 514
Partials 141 141 |
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
This was referenced Dec 23, 2022
This was referenced Dec 28, 2022
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Removes a redundant 'Buffer' type from the
Account
class.