patches range check in get_signed_message_range #27822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
Sep 16, 2022
(cherry picked from commit b183e00) # Conflicts: # ledger/src/shred.rs
behzadnouri
added a commit
that referenced
this pull request
Sep 16, 2022
…7831) * patches range check in shred::layout::get_signed_message_range (#27822) (cherry picked from commit b183e00) # Conflicts: # ledger/src/shred.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Inequality is reversed.
For current shreds
range.end == shred.len(), so this is a no-op.But for upcoming Merkle shreds this will cause shreds to incorrectly fail sig-verify.
Summary of Changes
Corrected the inequality direction.