Fixup log of Epoch Accounts Hash when freezing bank #27688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During testing, I found that the
bank frozenlog printed the EAH more than it was supposed to.Since the EAH is not cleared in Bank (but rather in
set_root()), once the EAH is saved by AHV, it'll beSome, and every bank that is frozen since will output the EAH. I don't think that is the desired behavior. I believe the behavior we want is to only log the EAH when it has been included in the bank's hash.Summary of Changes
Conditionally log EAH.