Respect rewards parameter in getBlock transaction-level rewards #27655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
reviewed
Sep 7, 2022
CriesofCarrots
force-pushed
the
respect-rewards
branch
from
e256d7c to
842f00a
Compare
CriesofCarrots
force-pushed
the
respect-rewards
branch
from
842f00a to
e44fe55
Compare
jstarry
approved these changes
Sep 8, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
* Respect options.show_rewards in UiTransactionStatusMeta * Fixup docs (cherry picked from commit 5428495)
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
* Respect options.show_rewards in UiTransactionStatusMeta * Fixup docs (cherry picked from commit 5428495)
mergify bot
added a commit
that referenced
this pull request
Sep 8, 2022
…port #27655) (#27669) Respect rewards parameter in getBlock transaction-level rewards (#27655) * Respect options.show_rewards in UiTransactionStatusMeta * Fixup docs (cherry picked from commit 5428495) Co-authored-by: Tyera Eulberg <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Sep 8, 2022
…port #27655) (#27670) Respect rewards parameter in getBlock transaction-level rewards (#27655) * Respect options.show_rewards in UiTransactionStatusMeta * Fixup docs (cherry picked from commit 5428495) Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
getBlockparameterrewardscurrently only affects whether block-level rewards are returned. Transaction-level rewards are returned regardless. While this isn't super critical with very few Rent payment, current behavior is a bit counterintuitive and may force clients to consume more data than they want to.Summary of Changes
Pass
show_rewardsinto UiTransactionStatusMeta constructors and only populate rewards when true.Also fixup docs to be correct